Bug #1

Insert MyCode problem (IE)

Added by Ryan Gordon over 3 years ago. Updated almost 2 years ago.

Status:Deferred Start date:11/09/2008
Priority:Normal Due date:
Assignee:- % Done:

0%

Category:Code/Post Editor
Target version:-
Reproducibility:Always Database Type:
Reported In MyBB Version:1.4.8 Database Version:
PHP Version: SQA assignments:
Browser:

Description

There's a problem in the editor using IE7.

Insert some text, then hit the quote button, insert some more text and hit the quote button again. You'll get something like this:
Some random text[quote][/quote]This text should be quoted
The close tag of the quote is always inserted right after the open tag. In Opera and Firefox there's no problem:
Some random text[quote]This text should be quoted[/quote]

Associated revisions

Revision 866
Added by Chris Boulton over 6 years ago

MySQL 5 fixes #1

Revision 867
Added by Chris Boulton over 6 years ago

MySQL 5 fixes #1

Revision 4445
Added by Tom Moore over 2 years ago

Fixes 1.4.6, pgsql, 'move thread' gives SQL error (fixes:414)

Revision 5037
Added by Ryan Gordon over 1 year ago

Fixes 1.4 -> 1.6 CSS Upgrade (fixes:1025)

Revision 5041
Added by Ryan Gordon over 1 year ago

Fixes 1.4 -> 1.6 CSS Upgrade (fixes:1025)

History

Updated by Ryan Gordon about 3 years ago

  • Target version changed from 5 to 1.4.4

Updated by Chris Boulton about 3 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset r866.

Updated by Chris Boulton about 3 years ago

Applied in changeset r867.

Updated by Chris Boulton about 3 years ago

  • Status changed from Resolved to Assigned
  • % Done changed from 100 to 0

Updated by Ryan Gordon about 3 years ago

  • Target version changed from 1.4.4 to 1.4.5

Updated by Ryan Gordon over 2 years ago

  • Target version changed from 1.4.5 to 1.4.7

Updated by Ryan Gordon over 2 years ago

  • Target version changed from 1.4.7 to 1.4.8

Updated by Ryan Gordon over 2 years ago

  • Target version changed from 1.4.8 to 1.4.9

Updated by Tom Moore over 2 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100
  • Reported In MyBB Version set to 1.4.8

Applied in changeset r4445.

Updated by Tom Moore over 2 years ago

  • Status changed from Resolved to Assigned
  • % Done changed from 100 to 0
  • Reproducibility set to Always

r4445 does not resolve #1.

Updated by Ryan Gordon over 2 years ago

  • Target version changed from 1.4.9 to 1.4.10

Updated by Ryan Gordon about 2 years ago

  • Target version deleted (1.4.10)

Updated by Ryan Gordon about 2 years ago

  • Status changed from Assigned to New
  • Assignee deleted (Chris Boulton)

Updated by Ryan Gordon about 2 years ago

Does this still happen?

Updated by Michael Schlechtinger about 2 years ago

  • Status changed from New to Confirmed

Yes (tested in IE8).

Updated by Ryan Gordon about 2 years ago

And the reproducibility is definately consistent?

Updated by Michael Schlechtinger about 2 years ago

Yeah. It's happening in MyBB 1.4.11 and in the trunk using IE.

Updated by Huji Lee about 2 years ago

Since this bug is related to the use of ranges, I guess it is related to bug #391.

Updated by Huji Lee almost 2 years ago

It is working correctly for me if I the editor doesn't lose focus. So, in IE7:

I put some text, click on the quote button, put more text and click on quote button and it works smoothly.

What makes it behave differently (and not the way mentioned in the first post of this bug, but still not the way it should be) in IE7 is:

I pust some text, click on quote button,put more text, now I click outside the editor. If I click the quote button at this point, the closing quote as added "at the beginning" of the text, not where the cursor used to be.

This is exactly why I think bug #391 is relevant. They are both about how IE handles ranges.

Updated by Ryan Gordon almost 2 years ago

  • Status changed from Confirmed to Deferred

I presume this should not happen once we move over to jQuery and new libraries in 2.0.

Also available in: Atom PDF