Bug #1582
settings.php writeable check
| Status: | Closed | Start date: | 05/16/2011 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 100% |
|
| Category: | - | |||
| Target version: | - | |||
| Reproducibility: | Always | Database Type: | ||
| Reported In MyBB Version: | 1.6.3 | Database Version: | ||
| PHP Version: | SQA assignments: | Spencer | ||
| Browser: |
Description
When saving settings in admincp the settings.php chmod is not checked, hence if settings.php chmod gets changed to non-writeable any setting changed in admincp is saved in the database and a success message is also shown but the board continues to use the old values since settings.php could not be updated. What makes this even more confusing for the end user is that the setting value will be shown as changed in the admincp (since its read from the database) even though its not changed in settings.php
The change I propose is to have a check before saving the settings and if settings.php is not writeable throw an error and don't save the setting.
Another addition to this that would be helpful would be to have a banner message in admincp informing the admins that settings.php is not writeable so that it can be addressed.
Associated revisions
Fixes settings.php writeable check (fixes #1582)
History
#1 Updated by D B about 1 year ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
Applied in changeset r5466.
#2 Updated by Spencer Swords about 1 year ago
- Status changed from Resolved to Closed
- SQA assignments set to Spencer