Bug #1736
Usertitle query in member.php to cache
| Status: | Closed | Start date: | 09/28/2011 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | Tom Moore | % Done: | 100% |
|
| Category: | Performance | |||
| Target version: | 1.6.7 | |||
| Reproducibility: | Always | Database Type: | ||
| Reported In MyBB Version: | 1.6.4 | Database Version: | ||
| PHP Version: | SQA assignments: | Nathan Malcolm | ||
| Browser: |
Description
Inside member.php:
// No usergroup title so get a default one
$query = $db->simple_select("usertitles", "*", "", array('order_by' => 'posts', 'order_dir' => 'DESC'));
while($title = $db->fetch_array($query))
Should be changed to user the cache instead. One less query. :)
Associated revisions
Fixes Usertitle query in member.php to cache (fixes #1736)
History
#1 Updated by Jesse Labrocca 8 months ago
Actually 2 places in that file.
// This is for cases where the user has a title, but the group has no defined number of stars (use number of stars as per default usergroups)
$query = $db->simple_select("usertitles", "*", "", array('order_by' => 'posts', 'order_dir' => 'DESC'));
while($title = $db->fetch_array($query))
#2 Updated by Tom Moore 6 months ago
- Status changed from New to Assigned
- Assignee set to Tom Moore
- Target version set to 1.6.6
#3 Updated by Tom Moore 6 months ago
- Status changed from Assigned to Resolved
- % Done changed from 0 to 100
Applied in changeset r5662.
#4 Updated by Nathan Malcolm 6 months ago
- Status changed from Resolved to Closed
- SQA assignments set to Nathan Malcolm