Bug #1938

reputation.php and usereputationsystem

Added by Jesse Labrocca 4 months ago. Updated 26 days ago.

Status:Closed Start date:02/08/2012
Priority:Normal Due date:
Assignee:Tom Moore % Done:

100%

Category:Reputation system
Target version:1.6.8
Reproducibility:Always Database Type:
Reported In MyBB Version:1.6.5 Database Version:
PHP Version: SQA assignments:Nathan Malcolm
Browser:

Description

If you have a group set for "usereputationsystem" = 0 (not displayed) and a group set 1 there is a bug. When you have your display group as the 0 you will properly not see the rep in the profile or the postbit. However you can still navigate to the rep by reputation.php?uid=X and if the user is part of another group that has a usereputationsystem=1 then the rep is visible.

I don't believe that's intended. Relevant code in reputation.php is

// Otherwise, show a listing of reputations for the given user.
if(!$mybb->input['action'])
{
    if($user_permissions['usereputationsystem'] != 1)
    {
        error($lang->reputations_disabled_group);
    }

So it's grabbing the $user_permissions but not the display group permission.

I hope this will get fixed eventually. If I recall I may have reported it a long time ago. It's bothersome I have my rep off and yet people can still see it.

Associated revisions

Revision 5792
Added by Tom Moore about 1 month ago

Fixes reputation.php and usereputationsystem (fixes #1938)

Revision 5802
Added by Tom Moore about 1 month ago

Fixes reputation.php and usereputationsystem (fixes #1938)

History

#1 Updated by Tom Moore about 1 month ago

  • Target version set to 1.6.8

#2 Updated by Tom Moore about 1 month ago

  • Category set to Reputation system
  • Status changed from New to Assigned
  • Assignee set to Tom Moore

#3 Updated by Tom Moore about 1 month ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset r5792.

#4 Updated by Nathan Malcolm about 1 month ago

  • Status changed from Resolved to Feedback
  • SQA assignments set to Nathan Malcolm

If the user's display group is set to Use Primary User Group then you'll recieve the "Reputation is disabled for users in this group" error when clicking on the link to their reputation.

#5 Updated by Tom Moore about 1 month ago

  • Status changed from Feedback to Resolved

Applied in changeset r5802.

#6 Updated by Nathan Malcolm 26 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF