Feature #210

Make permissions clearer

Added by Justin S about 3 years ago. Updated about 2 years ago.

Status:Closed Start date:03/22/2009
Priority:Normal Due date:06/12/2009
Assignee:Ryan Gordon % Done:

100%
Category:Admin Control Panel
Target version:1.6.0 Beta

Description

See the attached files for more information. The first is the permissions tab when viewing a forum, the second is what is displayed when you click on "Set Custom Permissions" or "Edit Permissions." Also, the "Overview" will be drag-and-drop-able. The overview just lists the primary, "important" permissions.

permissions2.jpg - Permissions view (457.8 kB) Justin S, 03/22/2009 03:37 pm

permissions3.jpg - Edit permissions (411 kB) Justin S, 03/22/2009 03:37 pm

Snap_2010.04.22_16.33.59_002.png (41.1 kB) Michael Malin, 04/22/2010 09:35 am

Related issues

duplicated by MyBB - Bug #902: Quick Perms does not work in Sharepoint Closed 04/27/2010

Associated revisions

Revision 4349
Added by Ryan Gordon about 3 years ago

Fixes Remove moderator and usergroup issue (fixes:229)
Fixes fetch_longipv4_range() and placeholders (fixes:230)
Feature Make permissions clearer (fixes:210) - 20% done

Revision 4361
Added by Ryan Gordon about 3 years ago

Updating prototype and scriptaculous to latest stable
WIP Feature Make Permissions Clearer (fixes:210) ~50% complete

Revision 4366
Added by Ryan Gordon about 3 years ago

WIP Feature Make permissions clearer (fixes:210) ~70% complete

Revision 4371
Added by Ryan Gordon about 3 years ago

Feature Make permissions clearer (WIP:210) (~80% complete)

Revision 4376
Added by Ryan Gordon almost 3 years ago

Feature Make permissions clearer (WIP:210) (~90% complete)
Fixes Admin Logs filter by module (fixes:273)
Fixes Update version check & news url (fixes:274)

Revision 4422
Added by Ryan Gordon almost 3 years ago

Feature View own threads only (completes:44)
Improves Make permissions clearer (improves:210)
Fixes capitalized LIMIT clause in db abstraction layer queries (fixes:360)

Revision 4488
Added by Ryan Gordon over 2 years ago

Fixes Make permissions clearer (fixes:210)

Revision 4489
Added by Ryan Gordon over 2 years ago

Fixes Make permissions clearer (fixes:210)

History

#1 Updated by Ryan Gordon about 3 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset r4349.

#2 Updated by Ryan Gordon about 3 years ago

  • % Done changed from 100 to 20

#3 Updated by Ryan Gordon about 3 years ago

  • % Done changed from 20 to 50

#4 Updated by Ryan Gordon about 3 years ago

  • Status changed from Resolved to Assigned

#5 Updated by Ryan Gordon about 3 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 50 to 100

Applied in changeset r4361.

#6 Updated by Ryan Gordon about 3 years ago

  • Status changed from Resolved to Assigned
  • % Done changed from 100 to 50

#7 Updated by Ryan Gordon about 3 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 50 to 100

Applied in changeset r4366.

#8 Updated by Ryan Gordon about 3 years ago

  • Status changed from Resolved to Assigned
  • % Done changed from 100 to 70

#9 Updated by Ryan Gordon about 3 years ago

  • % Done changed from 70 to 80

#10 Updated by Ryan Gordon almost 3 years ago

  • % Done changed from 80 to 90

#11 Updated by Ryan Gordon almost 3 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 90 to 100

Completed in commit #4381

#12 Updated by Stefan T. almost 3 years ago

If you submit a change, all group permissions are marked as custom although I did not edit all of them. It breaks the inheritance and you have to reset each group.

I had problems because the cache "forumpermissions" wasn't updated after clearing the permissions for a group.

#13 Updated by Ryan Gordon almost 3 years ago

  • Due date set to 06/12/2009

#14 Updated by Ryan Gordon over 2 years ago

  • Status changed from Resolved to Feedback

#15 Updated by Ryan Gordon over 2 years ago

  • Status changed from Feedback to Resolved

Applied in changeset r4488.

#16 Updated by Ryan Gordon over 2 years ago

Applied in changeset r4489.

#17 Updated by Michael Schlechtinger over 2 years ago

I encountered this problem several times: After creating a new forum no user group has any permissions on that forum. It's happening using Opera 10.01.

#18 Updated by Ryan Gordon over 2 years ago

Just Opera? Sounds like an Opera bug.

#19 Updated by Michael Schlechtinger over 2 years ago

Ryan Gordon wrote:

Just Opera? Sounds like an Opera bug.

I'm not sure. Sometimes it's working and sometimes it's not. But I don't know why. The only thing I found is this entry in the errror logs:

JavaScript - http://localhost/mybb/admin/index.php?module=forum-management&action=edit&fid=2
Event thread: load
Error:
name: TypeError
message: Statement on line 3966: Cannot convert undefined or null to Object
stacktrace:   Line 3966 of linked script http://localhost/mybb/jscripts/prototype.js
          handler.call(element, event);
  ...

#20 Updated by Nick Palmer over 2 years ago

On a side note, if you disable javascript, it doesn't seem to "show" the saved permissions, is that intended?

#21 Updated by Tom Moore over 2 years ago

I had a few problems using Opera and the old permissions. The same happens to the new-style permissions and with Opera 10.1.

Sometimes the permissions set OK but if I edit a forum and just hit save and edit nothing else, it will totally wipe out all the permissions and nobody sees anything. I then have to go back in, and reset the permissions.

#22 Updated by Ryan Gordon over 2 years ago

Can you debug it then, since you're able to reproduce?

#23 Updated by Michael Malin about 2 years ago

  • File Snap_2010.04.22_16.06.15_001.png added

There's a bug when using SharePoint. And there the entire properties are not defined. (Details in the screenshot)

Solution:

Find in /admin/styles/sharepoint/main.css the following code:

.view_fields li {
    -moz-border-radius: 3px;
    padding: 4px;
    background: #666;
    color: #fff;
    font-size: 11px;
    margin-bottom: 2px;
    margin-right: 10px;
}

And add after this:

.quick_perm_fields .enabled, .quick_perm_fields .disabled {
    width: 49%;
    float: left;
}

.quick_perm_fields .enabled {
    border-right: 5px solid #666;
}

.quick_perm_fields .disabled {
    float: right;
    margin-left: 0px;
}

.quick_perm_fields .fields_title {
    font-weight: bold;
    font-size: 120%;
}

.quick_perm_fields ul, .quick_perm_fields li {
    list-style: none;
    padding: 3px;
    margin: 0;
}

.quick_perm_fields ul {
    overflow: auto; // Scroll fix for Opera
    overflow-y: auto;
    overflow-x: hidden;
    height: 120px;
    margin-top: 4px;
}

.quick_perm_fields li {
    -moz-border-radius: 3px;
    padding: 4px;
    background: #666;
    color: #fff;
    font-size: 11px;
    margin-bottom: 2px;
    margin-right: 10px;
}

I have tested this solution on my test board and it works in any case with me.

#24 Updated by Stefan T. about 2 years ago

  • Status changed from Resolved to Feedback

#25 Updated by Stefan T. about 2 years ago

  • File deleted (Snap_2010.04.22_16.06.15_001.png)

#26 Updated by Michael Malin about 2 years ago

Here is a screenshot.

#27 Updated by Stefan T. about 2 years ago

If you edit a forum and there are custom permissions, all changes on the forum settings are lost when you click the "Clear Custom Permissions" link.

#28 Updated by Ryan Gordon about 2 years ago

Stefan T. wrote:

If you edit a forum and there are custom permissions, all changes on the forum settings are lost when you click the "Clear Custom Permissions" link.

Yes, that is intended. When you click that link you are moving away from that page to clear the permissions. It is not an AJAX response.

#29 Updated by Michael Malin about 2 years ago

Applied in changeset r4909. (http://dev.mybboard.net/issues/902#note-1)
Please set it to resolved.

#30 Updated by Tom Moore about 2 years ago

  • Status changed from Feedback to Resolved

Sorry Michael - I did see this report but thought it as a seperate bug (so a different report).

I'll set this as resolved - but if there's any new issues, can there be a seperate report please...

#31 Updated by Stefan T. about 2 years ago

Ryan Gordon wrote:

Stefan T. wrote:

If you edit a forum and there are custom permissions, all changes on the forum settings are lost when you click the "Clear Custom Permissions" link.

Yes, that is intended. When you click that link you are moving away from that page to clear the permissions. It is not an AJAX response.

Ok, but I think it is not clear for the users...

#32 Updated by Michael Malin about 2 years ago

  • Status changed from Resolved to Closed

I have now tested this feature and could not find any more errors. I think that even if errors occur, a separate ticket should be done because otherwise you lose track.

Also available in: Atom PDF