MyBB

Sighhh.. Tom! lol

Eeeep... at least the pagination works "properly" now! =P

A regression caused by #141

Tom Moore wrote:

Ryan, the change made in r4599 leads to a pgSQL error when you visit a thread. "lastpost" needs to be in a GROUP BY clause.

As switch statement should have been used. If there isn't one used then how am I supposed to know there is required syntax individual to a specific sql engine?

Ryan Gordon wrote:

As switch statement should have been used. If there isn't one used then how am I supposed to know there is required syntax individual to a specific sql engine?

See #414 (in particular, r4464). I changed the query to include the GROUP BY clause to fix issue 414, which you closed off. Does this feature not work if GROUP BY is used?

I closed it because they have to be closed in RedMine (up until Chris updated a few days ago) to mark a version of MyBB a 'completed' in the roadmap so we don't mislead users.

In addition, we need to be as optimized as possible in SQL. There is no reason that is needed on MySQL, so let's not use it there. Places like NCAAbbs depend on us having very optimized queries

That being said, the proper solution is to add a switch statement. Does SQLite need the GROUP BY as well?