Feature #24

Group as moderator

Added by Ryan Gordon over 3 years ago. Updated over 1 year ago.

Status:Closed Start date:11/17/2008
Priority:Normal Due date:01/26/2009
Assignee:Ryan Gordon % Done:

100%
Category:Other
Target version:1.6.0 Final

Description

Add the ability to assign an entire group as a "moderator" for a specific forum.

Database Schema changes: add 'isgroup' column. Either rename 'uid' column to 'id' or add a 'gid' column. This decision can be made at the discretion of the developer implementing this feature.

Related issues

blocked by MyBB - Bug #790: Moderator cleanup doesn't take care about group/user status Closed 03/04/2010
blocked by MyBB - Bug #1055: Non-moderator shown as moderator Closed 06/29/2010

Associated revisions

Revision 3389
Added by Chris Boulton over 4 years ago

fixes #16, #24, #21

Revision 4313
Added by Sergio Montoya about 3 years ago

Fixes some possible SQL injection, added AJAX and fixed a typo in Feature #24 (Fixes #24)

Revision 4415
Added by Tom Moore over 2 years ago

Fixes SQL Error when installing on SQLite (fixes:244)
WIP Feature Mass actions for users in the ACP (wip:31)
Improves Only receive PMs from buddies (improves:29)
Improves Group as moderator (improves:24)

Revision 4724
Added by Tom Moore about 2 years ago

Improves Group as moderator (improves:24)

Revision 4917
Added by Huji Lee almost 2 years ago

Improves Group as moderator (improves:24)
Also removes two deprecated language messages (one of which is redefined later in the code)

Revision 5137
Added by Ryan Gordon over 1 year ago

Fixes Group as moderator (fixes:24)

History

#1
Updated by Sergio Montoya over 3 years ago

  • Assignee set to Sergio Montoya

#2
Updated by Ryan Gordon over 3 years ago

  • Status changed from New to Assigned

#3
Updated by Chris Boulton about 3 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset r3389.

#4
Updated by Chris Boulton about 3 years ago

  • Status changed from Resolved to Assigned
  • % Done changed from 100 to 0

#5
Updated by Sergio Montoya about 3 years ago

  • Status changed from Assigned to Feedback
  • % Done changed from 0 to 100

#6
Updated by Sergio Montoya about 3 years ago

  • Status changed from Feedback to Resolved

Applied in changeset r4313.

#7
Updated by Ryan Gordon over 2 years ago

  • Assignee changed from Sergio Montoya to Ryan Gordon

#8
Updated by Ryan Gordon over 2 years ago

  • Due date set to 01/26/2009

#9
Updated by Tom Moore over 2 years ago

There was a database error when trying to delete a user from the ACP. Fixed in revision 4415.

#10
Updated by Doug Sisk over 2 years ago

  • Status changed from Resolved to Closed

#11
Updated by Chris R over 2 years ago

There is a small issue with this when adding a group as a moderator. Say you have two groups with the same name and they are for different people so to say. how does it know what one to use. With the drop down bit that comes up maybe it should show the group id

EG: Administrator (GID: 4)
Administrator (GID: 8)

#12
Updated by Ryan Gordon about 2 years ago

  • Status changed from Closed to Feedback

report.php needs to be updated appropriately.

#13
Updated by Tom Moore about 2 years ago

  • Status changed from Feedback to Resolved

Updated report.php in r4724. (Sorry Ryan, jumping in!).

Chris, that solution isn't that plausible, as you'd have to remove "GID: x" in the commit process - which would need some ugly regex. The groups are sorted by GID when they're retrieved from the database, so any you've added will be at the bottom of the list.

#14
Updated by Fire Star about 2 years ago

SO this feature is finished?

#15
Updated by Dennis Tsang about 2 years ago

Completed yes.
Bugfree maybe not.

#16
Updated by Fire Star about 2 years ago

I have really been wanting this feature so goodluck!

#17
Updated by Huji Lee almost 2 years ago

I made it more bug-free with r4799 and r4800.

#18
Updated by Stefan T. almost 2 years ago

  • Status changed from Resolved to Feedback

1) There are input boxes for adding usergroups and users, but you can just use one, not both together. Perhaps we could separate both parts and use different buttons.
2) The button for adding moderators says "Add Moderator(s)". All other messages (flash, buttons,...) just use "moderator".
3) If you want to add a group that is already moderator, you get this message: "The selected user is already a moderator of this forum."

#19
Updated by Stefan T. almost 2 years ago

4) If you try to add a group that doesn't exist: "The specified username was not found."
5) If you add a normal user to moderate a forum he gets into the moderators group. But if you delete all moderation rights of him, he is still in the moderators group.

#20
Updated by Huji Lee almost 2 years ago

3 and 4 are fixed with r4917.

#21
Updated by Ryan Gordon over 1 year ago

Please report the other unresolved issues as separate issues against 1.6.1 and mark this as closed when possible.

#22
Updated by Ryan Gordon over 1 year ago

  • Target version changed from 1.6.0 Beta to 1.6.0 Final

#23
Updated by Ryan Gordon over 1 year ago

  • Status changed from Feedback to Resolved

Applied in changeset r5137.

#24
Updated by Ryan Gordon over 1 year ago

1, 2, and 5 are fixed with r5137

#25
Updated by Manuel Feller over 1 year ago

  • Status changed from Resolved to Feedback

I cannot seem to close this ticket :x There's only Resolved and Feedback in the dropdown box.

#26
Updated by Ryan Gordon over 1 year ago

The tickets that "block" this up above make it unable to be closed until the other blocking tickets are closed.

#27
Updated by Ryan Gordon over 1 year ago

  • Status changed from Feedback to Resolved

#28
Updated by Michael Malin over 1 year ago

  • Status changed from Resolved to Closed

It looks good.

Also available in: Atom PDF