Bug #322
HTML in forum names in 1.4.8
| Status: | Closed | Start date: | 07/07/2009 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | Tom Moore | % Done: | 100% |
|
| Category: | Forum Display | |||
| Target version: | 1.4.10 | |||
| Reproducibility: | Database Type: | |||
| Reported In MyBB Version: | 1.4.8 | Database Version: | ||
| PHP Version: | SQA assignments: | |||
| Browser: |
Description
In 1.4.8, the navigation was changed to fix this bug: http://community.mybboard.net/thread-50291.html
This "broke" the HTML allowed in forum names: http://community.mybboard.net/attachment.php?aid=14496
Associated revisions
Fixes HTML in forum names in 1.4.8 (fixes:322)
History
Updated by Tom Moore over 2 years ago
The suggestion is to replace the htmlspecialchars_uni in the navigation with a replacement for & (to &).
This should keep the conformity of the previous releases while attempting to fix a problematic valid html error.
Updated by Dennis Tsang over 2 years ago
Only if it's not being used as one of those special characters, right?
Updated by Tom Moore over 2 years ago
It would replace just a plain "&", and nothing in a special character. So "Forum & Posts" will become "Forum (amp) Posts"
Updated by Tom Moore over 2 years ago
- Status changed from Assigned to Resolved
- % Done changed from 0 to 100
- Reported In MyBB Version set to 1.4.8
Applied in changeset r4443.
With this changeset, I've replaced htmlspecialchars_uni with a preg_replace; this is to provide global support for unicode in forum names. Different places in MyBB used different functions to parse the forum names, so for some level of conformity, I've altered these places (ACP forum management, forumdisplay and navigation).
So, this means characters such as » can't be used; its unicode equivilant ("»") should be used instead.
Updated by Chris W. B. over 2 years ago
- Status changed from Resolved to Closed
Updated by Ryan Gordon over 2 years ago
- Target version changed from 1.4.9 to 1.4.10