Bug #323

Delete a PM using the delete button

Added by Tom Moore over 2 years ago. Updated over 2 years ago.

Status:Closed Start date:07/07/2009
Priority:Normal Due date:
Assignee:Tom Moore % Done:

100%
Category:Private Messages
Target version:1.4.10
Reproducibility: Database Type:
Reported In MyBB Version:1.4.8 Database Version:
PHP Version: SQA assignments:
Browser:

Description

If you open a PM in the trash folder and click on the delete button the message remains in the trash folder.

Fix (private.php):

$sql_array = array(
    "folder" => 4,
    "deletetime" => TIME_NOW
);
$db->update_query("privatemessages", $sql_array, "pmid='".intval($mybb->input['pmid'])."' AND uid='".$mybb->user['uid']."'");
$query = $db->simple_select("privatemessages", "*", "pmid='".intval($mybb->input['pmid'])."' AND uid='".$mybb->user['uid']."' AND folder='4'", array('order_by' => 'pmid'));
if($db->num_rows($query) == 1)
{
    $db->delete_query("privatemessages", "pmid='".intval($mybb->input['pmid'])."'");
}
else
{
    $sql_array = array(
        "folder" => 4,
        "deletetime" => TIME_NOW
    );
    $db->update_query("privatemessages", $sql_array, "pmid='".intval($mybb->input['pmid'])."' AND uid='".$mybb->user['uid']."'");
}

Associated revisions

Revision 4393
Added by Tom Moore over 2 years ago

Fixes search_results_inlinemodcol Template Oversight (fixes:318)
Fixes Forum announcements trow do not alternate (fixes:319)
Fixes Mod-CP - Edit User & Birthday (fixes:320)
Fixes Future mass mailings (fixes:321)
Fixes Delete a PM using the delete button (fixes:323)
Fixes Maximum length in Custom Profile Fields do not work (fixes:324)

History

#1
Updated by Tom Moore over 2 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset r4393.

#2
Updated by Chris W. B. over 2 years ago

  • Status changed from Resolved to Closed

#3
Updated by Ryan Gordon over 2 years ago

  • Target version changed from 1.4.9 to 1.4.10
  • Reported In MyBB Version set to 1.4.8

Also available in: Atom PDF