Feature #41

Select all (like Gmail)

Added by Ryan Gordon over 3 years ago. Updated almost 2 years ago.

Status:Closed Start date:11/17/2008
Priority:Normal Due date:07/12/2009
Assignee:Ryan Gordon % Done:

100%

Category:Other
Target version:1.6.0 Beta

Description

  • something like Gmail when you select "All" of the current page, it will also ask you "Also select 10000 other threads in the search?"
  • applied to anywhere we have inline moderation/checkboxes used in this manner

selectall.png - Mockup for this feature (324.3 kB) Justin S, 12/17/2008 11:38 pm

Associated revisions

Revision 4395
Added by Ryan Gordon almost 3 years ago

Feature Select all (like Gmail) (completed:41)

Revision 4396
Added by Ryan Gordon almost 3 years ago

Feature Select all (like Gmail) (completed:41)

Revision 4425
Added by Ryan Gordon almost 3 years ago

Improves Select All (like Gmail) (improves:41)

Revision 4506
Added by Justin S over 2 years ago

Improves Select all (like Gmail) (improves:41)

Revision 4507
Added by Justin S over 2 years ago

Improves Select all (like Gmail) (improves:41)

Revision 4617
Added by Ryan Gordon over 2 years ago

Fixes Select all (like Gmail) (fixes:41)

Revision 4618
Added by Ryan Gordon over 2 years ago

Improves Select all (like Gmail) (improves:41)

Revision 4619
Added by Ryan Gordon over 2 years ago

Improves Select all (like Gmail) (improves:41)

Revision 4848
Added by Ryan Gordon about 2 years ago

Fixes Select all (like Gmail) (fixes:41)

History

#1 Updated by Sergio Montoya over 3 years ago

  • Assignee set to Sergio Montoya

#2 Updated by Sergio Montoya over 3 years ago

  • Status changed from New to Assigned

#3 Updated by Justin S over 3 years ago

#4 Updated by Ryan Gordon over 3 years ago

  • Due date set to 01/31/2009

#5 Updated by Sergio Montoya about 3 years ago

  • % Done changed from 0 to 70

Just have to finish search.php

#6 Updated by Ryan Gordon about 3 years ago

  • Due date changed from 01/31/2009 to 05/16/2009

#7 Updated by Ryan Gordon almost 3 years ago

  • Assignee deleted (Sergio Montoya)

#8 Updated by Ryan Gordon almost 3 years ago

  • Status changed from Assigned to New

#9 Updated by Ryan Gordon almost 3 years ago

  • Due date deleted (05/16/2009)
  • Start date deleted (11/17/2008)

#10 Updated by Ryan Gordon almost 3 years ago

  • Assignee set to Ryan Gordon
  • % Done changed from 70 to 100

#11 Updated by Ryan Gordon almost 3 years ago

  • Status changed from New to Resolved

Applied in changeset r4395.

#12 Updated by Ryan Gordon almost 3 years ago

Applied in changeset r4396.

#13 Updated by Ryan Gordon almost 3 years ago

  • Due date set to 07/12/2009
  • Start date set to 11/17/2008

#14 Updated by Nick Palmer almost 3 years ago

Two things. First when you do the select all, it seems like all is good, but if you do a moderator action on them (like close them for instance), nothing happens to them.

The other thing is it seems to have a problem if you have one thread per forum, though I realize no one uses that.

#15 Updated by Ryan Gordon over 2 years ago

  • Status changed from Resolved to Feedback

#16 Updated by Ryan Gordon over 2 years ago

  • Status changed from Feedback to Resolved

Applied in changeset r4617.

#17 Updated by Ryan Gordon over 2 years ago

  • Subject changed from Select all… (like Gmail) to Select all (like Gmail)

#18 Updated by Justin S over 2 years ago

Just noticed this - when you click on the "Select all ## threads in this forum." link, the link changes to "Clear Selection" and all of the threads are selected - but the text immediately before it still says "All 20 threads on this page are selected." Shouldn't it say "All ## threads in this forum are selected" instead?

#19 Updated by Ryan Gordon over 2 years ago

  • Status changed from Resolved to Feedback

#20 Updated by Huji Lee about 2 years ago

I can't replicate the issue raised by Justin. Not only my link shows the correct number, but also I think the current revision is unable to show a wrong number because the correct number of threads is put inside the text using sprintf.

However, I want to raise a different issue: In the default installation using the default theme, the select all and clear selection links never show up; they are both styled as "hiddenrow" and remain hidden.

#21 Updated by Justin S about 2 years ago

I think you misunderstood. The numbers are all correct until you click "Select all ## threads in this forum." (where ## is the correct number of threads in that forum). When you do select it, the link changes to clear selection; however, the "All ## threads on this page are selected." (where ## is the number of threads on that page) does not change.

For instance, I currently have my forum set to display 2 threads per page. There are 3 threads in the forum. Clicking the select all check box adds this message:

"All 2 threads on this page are selected. Select all 3 threads in this forum."

Clicking on the "Select all 3 threads in this forum" link changes the message to this:

"All 2 threads on this page are selected. Clear Selection."

All of the threads are properly selected; however, as you can see, the message does not change to represent that. It should instead say something like this:

"All 3 threads in this forum are selected. Clear Selection."

#22 Updated by Ryan Gordon about 2 years ago

  • Status changed from Feedback to Resolved

Applied in changeset r4848.

#23 Updated by Stefan T. almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF