Bug #457
Double Template Rows
| Status: | Closed | Start date: | 09/06/2009 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | Tom Moore | % Done: | 100% |
|
| Category: | Admin Control Panel | |||
| Target version: | 1.4.10 | |||
| Reproducibility: | Rarely | Database Type: | ||
| Reported In MyBB Version: | 1.4.8 | Database Version: | ||
| PHP Version: | SQA assignments: | |||
| Browser: |
Description
Not sure exactly how it happens, but once when I was editing a template (groupimage) the link turned blue (to signify a custom template) and I later found it there were two groupimage rows in the template table.
I deleted one and it works now, but the link is still blue. Another person had this duplicate row issue, but his link is not blue. That may be a separate issue.
Newer thread: http://community.mybboard.net/thread-56130.html
Associated revisions
Fixes Double Template Rows (fixes:457)
History
Updated by Matt Rogowski over 2 years ago
I'm working on trying to figure out reproduction steps. It's similar to http://community.mybboard.net/thread-50240.html in the sense that the master gets deleted and the remaining template is custom, meaning it won't be displayed, the difference being it's seemingly more random and happens when you simply edit and save the template, on rare occasions.
The double template referred to here is the custom one being added, which is fine in itself, but it seems to delete the master in the process. To fix it you need a query to insert the default back: http://community.mybboard.net/thread-54609.html
Updated by Ryan Gordon over 2 years ago
Yeah, I'm going to need some reproduction steps before I can fix this.
Updated by Leon Z over 2 years ago
Any update in reproduction Matt? I haven't been able to.
Updated by Matt Rogowski over 2 years ago
Sorry, meant to update this sooner, I haven't managed to find any real reproduction steps but I'm still trying.
Updated by Matt Rogowski over 2 years ago
Found something wrong, bare with me whilst I attempt to explain (it's late and I'm tired :P).
OK. Go to any template set and edit any template. When you edit it, change the Template Set to Global Templates. It will disappear from the original template set and only be in the Global Template set.
It can be deleted from here, which means you can only get it back via SQL query, to get it to work properly again.
If you then move it back into the original template set, it will appear blue in the list, and changes made to it will still be applied to the forum itself. However you can also still delete this template.
I'm not totally sure if this is the exact same issue as the original bug report, that's more templates gong blue when they're just being edited normally, but I think this may be linked, and I've never been able to reproduce the 'random' blue-name problem.
Updated by Tom Moore over 2 years ago
If the user is intentionally switching the template from it's set to global, we can hardly call that a bug... :-/
I would point the finger at Codepress and a user's browser/user error. Haven't had a chance to replicate that though.
Updated by Matt Rogowski over 2 years ago
Tom Moore wrote:
If the user is intentionally switching the template from it's set to global, we can hardly call that a bug... :-/
Maybe but because you can then delete it, it'll cause problems. A lot of people click around things not really knowing what it'll do, if they put it in the global templates, they may then delete it from there, thinking it'll just go from there, not realising it'll be gone for good, and then they have no index template, which means a support request, and I'm sure people have done this in the past. I was under the impression it shouldn't be possible to delete default templates, which is why there's no delete option normally, but just moving them means you can delete them.
Issue #266
That was a similar thing, you could end up deleting a default template, this is another way it's possible.
Updated by Tom Moore over 2 years ago
OK - an easy way would be to check to see if a template has a "default" template (-2 in the database), and if it does, then don't show the "Which template set should this be in?" option.
Updated by Ryan Gordon about 2 years ago
- Category set to Admin Control Panel
- Status changed from New to Assigned
- Assignee set to Tom Moore
- Target version set to 1.4.10
Updated by Tom Moore about 2 years ago
- Status changed from Assigned to Resolved
- % Done changed from 0 to 100
Applied in changeset r4517.
Updated by Michael Schlechtinger about 2 years ago
- Status changed from Resolved to Closed