Bug #466

Last post date after custom merge

Added by Matt Rogowski over 2 years ago. Updated over 1 year ago.

Status:Closed Start date:09/24/2009
Priority:Normal Due date:
Assignee:Ryan Gordon % Done:

100%
Category:Moderation
Target version:1.6.0 Beta 2
Reproducibility:Rarely Database Type:
Reported In MyBB Version:1.4.8 Database Version:
PHP Version: SQA assignments:
Browser:

Description

I found this on the comm. forums, I'm reporting it as a bug here because a default feature has been used so the error would likely be in that.

I posted in a thread, it was at the top of the thread list after that. I then clicked a user's profile, viewed their threads, and merged three, one of which was the one I'd just posted in. They merged, but then on the index, the last post in the forum was the next newest thread after the one that got merged, the second thread in the forum. When I went into the forum, the newly merged thread was at the top, as it should be, went back to the index, the second thread was showing as being the last post.

I could try and reproduce if an admin could give the exact setup of this Mod tool in a PM or something.

screenshot.png (89.5 kB) Michael Schlechtinger, 11/28/2009 08:27 am

Associated revisions

Revision 4544
Added by Ryan Gordon about 2 years ago

Fixes Last post date after custom merge (fixes:466)

Revision 4557
Added by Ryan Gordon about 2 years ago

Fixes Last post date after custom merge (fixes:466)

Revision 5038
Added by Ryan Gordon over 1 year ago

Fixes Last post date after custom merge (fixes:466)

History

#1
Updated by Ryan Gordon about 2 years ago

  • Status changed from New to Assigned
  • Assignee set to Ryan Gordon
  • Target version set to 1.4.10

#2
Updated by Ryan Gordon about 2 years ago

We just need to update the lastpost information on the thread and forum tables as well it looks like

#3
Updated by Ryan Gordon about 2 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset r4544.

#4
Updated by Michael Schlechtinger about 2 years ago

This fix seems to be incomplete. It updates the data of the forum where the post is in but not the parent forum(s) (see screenshot).

Possible fix:

Open inc/class_moderation.php and find:

function merge_posts($pids, $tid=0, $sep="new_line")
{
    global $db, $plugins;

Replace with:
function merge_posts($pids, $tid=0, $sep="new_line")
{
    global $db, $plugins, $cache;

Find:
update_forum_data($fid);

Below add:
$cache->update_forums();

#5
Updated by Ryan Gordon about 2 years ago

  • Status changed from Feedback to Resolved

Applied in changeset r4557.

#6
Updated by Michael Schlechtinger about 2 years ago

  • Status changed from Resolved to Closed

#7
Updated by Matt Rogowski about 2 years ago

  • Status changed from Closed to Feedback

Sorry I opened another one, forgot I could do this.

This still happens. Re-worded reproduction steps:

Make threads 'One', 'Two', 'Three', 'Test'. Post in 'Three', so the orders are different.

Order, from top to bottom, is then 'Three', 'Test', 'Two', 'One'.

Merge 'Three', 'Two', 'One'.

Top thread on the forum display is 'One', last post info says 'Test'.

Reproduced on latest SVN and the community forums.

#8
Updated by Dennis Tsang about 2 years ago

Yup Matt, Imad, and Nick and I we were able to confirm this with the regular merge tool.

Create thread 1
Create thread 2
Create thread 3
Reply in thread 2
Merge thread 2 into thread 1 using the regular moderation.
The forum display shows thread 1 as the latest thread (which is correct because we last posted in 2 which is now in 1) but the forum info on the index pages show thread 3 as latest.

#9
Updated by Ryan Gordon about 2 years ago

  • Assignee changed from Ryan Gordon to Dennis Tsang
  • Target version changed from 1.4.10 to 1.4.12

#10
Updated by Ryan Gordon almost 2 years ago

.

#11
Updated by Ryan Gordon over 1 year ago

  • Status changed from Feedback to Assigned
  • Target version deleted (1.4.12)

#12
Updated by Ryan Gordon over 1 year ago

  • Status changed from Assigned to Confirmed
  • Assignee deleted (Dennis Tsang)

#13
Updated by Ryan Gordon over 1 year ago

  • Status changed from Confirmed to Resolved

Applied in changeset r5038.

#14
Updated by Ryan Gordon over 1 year ago

  • Assignee set to Ryan Gordon
  • Target version set to 1.6.0 Beta 2

#15
Updated by Polar Bear over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF