Bug #517

Incomplete theme exports

Added by Michael Schlechtinger over 2 years ago. Updated about 2 years ago.

Status:Closed Start date:11/03/2009
Priority:Normal Due date:
Assignee:Ryan Gordon % Done:

100%
Category:Activity Indicator System
Target version:1.4.10
Reproducibility:Rarely Database Type:
Reported In MyBB Version:1.4.8 Database Version:
PHP Version: SQA assignments:
Browser:

Description

Some users have problems exporting a theme. In their cases the content of the XML file is incomplete. Deleting the following line in admin/modules/style/themes.php solved the problem:

admin/modules/style/themes.php

I'm not sure about that but I think we have to use strlen() instead of my_strlen() here.

Associated revisions

Revision 4522
Added by Ryan Gordon about 2 years ago

Fixes Incomplete theme exports (fixes:517)

History

#1
Updated by Ryan Gordon over 2 years ago

Deleting which line?

#2
Updated by Michael Schlechtinger over 2 years ago

Ryan Gordon wrote:

Deleting which line?

Sorry, my fault. I meant this line:

header("Content-Length: ".my_strlen($xml));

#3
Updated by Ryan Gordon over 2 years ago

Yeah, that should use strlen instead of my_strlen since we are sending the total number of bytes consumed for each character, not just each individual character. I remember this being fixed in the branch quite a while ago. Did the fix never make it into the trunk?

#4
Updated by Michael Schlechtinger over 2 years ago

Ryan Gordon wrote:

Yeah, that should use strlen instead of my_strlen since we are sending the total number of bytes consumed for each character, not just each individual character. I remember this being fixed in the branch quite a while ago. Did the fix never make it into the trunk?

As far as I can see the fix is not in the branch and the trunk.

#5
Updated by Ryan Gordon about 2 years ago

  • Category set to Activity Indicator System
  • Status changed from New to Assigned
  • Assignee set to Ryan Gordon
  • Target version set to 1.4.10

#6
Updated by Ryan Gordon about 2 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset r4522.

#7
Updated by Michael Schlechtinger about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF