Bug #524

Slight typo in ./inc/functions.php

Added by Matt Rogowski over 2 years ago. Updated about 2 years ago.

Status:Closed Start date:11/06/2009
Priority:Normal Due date:
Assignee:Ryan Gordon % Done:

100%
Category:Other
Target version:1.4.10
Reproducibility:Always Database Type:
Reported In MyBB Version:1.4.8 Database Version:
PHP Version: SQA assignments:
Browser:

Description

From line 228:

/**
 * Sends a specified amount of messages from the mail queue
 *
 * @param int The number of messages to send (Defaults to 20)
 */
function send_mail_queue($count=10)

Partly OCD, partly a possible bug. I'm not sure which is correct, the value in the comment or the default in the function, i.e. I don't know if the default in the function is supposed to be 20 instead of 10, or if the 10 is right and the comment's wrong.

Don't hate me :(

Associated revisions

Revision 4521
Added by Ryan Gordon about 2 years ago

Fixes Slight typo in ./inc/functions.php (fixes:524)

History

#1
Updated by Matt Rogowski over 2 years ago

And I mean typo in the title, not type.

That's a bit ironic.

#2
Updated by Tom Moore over 2 years ago

  • Subject changed from Slight type in ./inc/functions.php to Slight typo in ./inc/functions.php

Matt Rogowski wrote:

And I mean typo in the title, not type.

That's a bit ironic.

:P

I thought the mail queue defaulted to 50... :-/

Is that function even used anywhere?

#3
Updated by Ryan Gordon over 2 years ago

Yes, it is used.

#4
Updated by Tom Moore over 2 years ago

Ryan Gordon wrote:

Yes, it is used.

Didn't expect it to be in the main function file as part of mail system - I see. -.-

#5
Updated by Ryan Gordon about 2 years ago

  • Category set to Other
  • Status changed from New to Assigned
  • Assignee set to Ryan Gordon
  • Target version set to 1.4.10

#6
Updated by Ryan Gordon about 2 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset r4521.

#7
Updated by Michael Schlechtinger about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF