MyBB

This is a very strange bug, so I'll do my best to explain it.

In the current 1.6, the finding guest/user posts query options are set like so:

$options = array(
    'limit' => intval($mybb->settings['searchhardlimit']),
    'order_by' => 'dateline',
    'order_dir' => 'desc',
);

If the searchhardlimit is set to 0 (disabled), then the query always returns 0 results. In 1.4, the query options are like this:

$options = array(
    'LIMIT' => intval($mybb->settings['searchhardlimit']),
    'order_by' => 'dateline',
    'order_dir' => 'DESC'
);

The capitalisation of the limit seems to make the query skip the fact the searchhardlimit setting is 0. If, for instance, you change it to lowercase (to standards, I guess), the query recognises this and returns 0 results. This isn't so much a bug in 1.4, as it works either way (if there is or isn't a setting).

A possible fix:

$options = array(
    'order_by' => 'dateline',
    'order_dir' => 'desc'
);

// Do we have a hard search limit?
$mybb->settings['searchhardlimit'] = intval($mybb->settings['searchhardlimit']);
if($mybb->settings['searchhardlimit'] > 0)
{
    $options['limit'] = $mybb->settings['searchhardlimit'];
}

An other option is to simply capitalise the limit in the 1.6 query options array and it will work as it does in 1.4.

So, which fix should I apply? And should I apply it to 1.4 too? I'd rather fix both to the above code...