MyBB

And this is consistent behavior?

Appears to be, it happens every time I edit a template. I can only assume it's a regression, I edited a template fine on 1.4.9, and three people have reported this behavior on the community forums. Maybe it's related to Issue #457??

The people who reported this also said it edited all templates with the same name across all template sets, which I imagine it would if the -2 template is being changed, however it didn't update all templates like this for me.

Eeeep... It is related to #457. Applying a fix shortly...

Applied in changeset r4583.

Working as expected now.

It's working in the branch but not the trunk. If you edit a template in the trunk version it's stored in the db correctly but the color of the name does not change in your ACP.

No, after you edited a template with sid -2 there is no entry with sid -2 for it anymore.

Are you sure? On my test installation I have two templates (sid=-2 and sid=1) which is correct.

Try to enter a different name. Than the original template is missing...

How many developers and SQA people does it take to fix 1 bug?

lol :p

I'll look into this.

I was able to reproduce Michael's problem. The regression was from r4317 - For some reason $template['gid'] was never set.

I was also able to reproduce Matt's/Stefan's issue with the master template still being updated. I'll try to repro again and fix it.

I've also been able to fix Stefan's issue.

Reproduction Instructions for Matt's issue (master templates being overridden)

1. Open any template and edit it template
2. Click "Save and Return to Listing"
3. Stop the browser from redirecting to the template listing but only AFTER it inserts the database record (You can simulate this by putting the php code "die();" in right before the admin_redirect function.
4. Press the refresh button on the browser (Say okay to any POST data transfer prompts)

This basically is a double submit problem. Because we originally relied on the tid being updated in the POST data from the form after the master template was updated in order to execute updates to the modified template, not updating the tid caused it to update the master template instead. I've also included safeguards to make sure this can't happen for any reason in the future as well.

P.S., please note michael you could only reproduce your issue on the trunk because it had to do with a new feature in MyBB 1.6 in the template lists.

SQA, please do an in-depth test of all the "edit" functionality of the template pages in this new commit

Applied in changeset r4637.

Ryan Gordon wrote:

Reproduction Instructions for Matt's issue (master templates being overridden) ...

Awesome, very happy to finally know what causes this!! That explains it perfectly, why it was rare and intermittent, it wouldn't be very often that it'd be interrupted.

The mentioned issues seem to be fixed. But I found another thing: You cannot move a custom template from a template set to the global templates.

Steps to reproduce:
1. Create a new template in a template set (not the global templates).
2. Edit this template and change the set it belongs to to "Global Templates".
3. Click "Save and return to listing".
4. You get redirected to the global templates list but your template isn't there.

Applied in changeset r4652.

SQA, just going to need a overall functionality test on the edit functionality in the template pages to confirm this.

I tested the trunk version and you cannot edit the default templates anymore. If you save the template you get a success message but the template is not stored in the database.

grr

Applied in changeset r4659.

This should definately fix everything. Even found another bug where if you had a global template called the same as a default template, it would show up as "green/modified" in the default template listing.

1) If you want to add a new template with the name of a default template you get this error message: "The template title is already in use. Please use a different title." If you edit a template and you enter the name of a default template there's no message and the template gets stored.

2) I don't know if this is intentional: If you move a template from the global templates into a template set the template also remains in the global templates list. There are 2 entries in the database (sid=-1 and sid=x).

Apart from that everything is working fine now. But I would like someone else to test this to make sure that there are no other flaws.

Applied in changeset r4662.

This only fixes issue 2 of michael's posted issues. Issue issue 1 is NAB

Applied in changeset r4665.