Bug #580

all backup files are messed, forward instead of backward quotes

Added by Henryk Trappmann about 2 years ago. Updated about 2 years ago.

Status:Closed Start date:12/09/2009
Priority:Normal Due date:
Assignee:Ryan Gordon % Done:

100%

Category:Other
Target version:1.4.11
Reproducibility:Always Database Type:MySQL
Reported In MyBB Version:1.4.10 Database Version:
PHP Version: SQA assignments:
Browser:

Description

The database backup files created in
Tools & Maintenance > Database backups

use for all fields in "INSERT INTO" statements forward quotes, instead of the needed backward quotes.

I just had the problem to recover my database and then there was this unusable file (I could fix it by a small perl script which replaced the affected quotes)!

Guys, a working backup is an essential part of the system.
I remember a time/version of mybb where the backup just contained empty zipped files! (What luck that I hadnt to recover my system in that time).

Please keep care of the backup!

Associated revisions

Revision 4594
Added by Ryan Gordon about 2 years ago

Fixes Mysql Backups - keys not quoted (fixes:307)
Fixes all backup files are messed, forward instead of backward quotes (fixes:580)

Revision 4595
Added by Ryan Gordon about 2 years ago

Fixes Mysql Backups - keys not quoted (fixes:307)
Fixes all backup files are messed, forward instead of backward quotes (fixes:580)

History

Updated by Matt Rogowski about 2 years ago

  • Priority changed from 6 to Normal

Please do not set a priority on reports, it's not your position to decide that.

Updated by Tom Moore about 2 years ago

Has this issue just started, Henryk?

I've just tried a backup, and looked at previous backups, and everything seems OK to me...

Updated by Henryk Trappmann about 2 years ago

Hm, if I look at the backup dates, it seems to occur after the update from 1.4.9 to 1.4.10.
In the backups before the fields have no quotes at all.
I vaguely remember that there is something like autoquotes in PHP, which depends on the PHP configuration of the server.
Perhaps it has to do with that.

Updated by Ryan Gordon about 2 years ago

Normal (') quotes work perfectly fine in MySQL.

Updated by Ryan Gordon about 2 years ago

  • Status changed from New to Rejected

Updated by Henryk Trappmann about 2 years ago

I dont know with what version of MySQL you work, but I dont know any where you can enclose field names in normal single quotes.
Either you put it in backquotes or in no quotes at all, otherwise you get a syntax error like this (on MySQL 5.0.70 and 5.0.84):

INSERT INTO mybb_adminlog( 'uid', 'ipaddress', 'dateline', 'module', 'action', 'data' )
VALUES (
'1', '77.137.37.82', '1241261952', 'tools/backupdb', 'backup', 'a:1:{i:0;s:8:\"download\";}'
);

MySQL said: Documentation
#1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''uid','ipaddress','dateline','module','action','data') VALUES ('1','77.137.37.82' at line 1

Updated by Ryan Gordon about 2 years ago

Oh nevermind, I thought you were talking about the values not the actual column names.

Looks like this is a regression from issue #307

Updated by Ryan Gordon about 2 years ago

  • Category set to Other
  • Status changed from Rejected to Assigned
  • Assignee set to Ryan Gordon
  • Target version set to 1.4.10

Updated by Ryan Gordon about 2 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset r4594.

Updated by Ryan Gordon about 2 years ago

Applied in changeset r4595.

Updated by Ryan Gordon about 2 years ago

This has been applied to the MyBB 1.4.10 download and MyBB 1.4.10 changed file package. We apologize for the inconvenience.

Updated by Stefan T. about 2 years ago

  • Status changed from Resolved to Closed

Updated by Dennis Tsang about 2 years ago

  • Target version changed from 1.4.10 to 1.4.11

Also available in: Atom PDF