Bug #586

Posts after updating the attachments of drafts

Added by Tim B. about 2 years ago. Updated over 1 year ago.

Status:Closed Start date:12/11/2009
Priority:Normal Due date:
Assignee:Tom Moore % Done:

100%
Category:New Thread
Target version:1.4.12
Reproducibility:Always Database Type:
Reported In MyBB Version:1.4.10 Database Version:
PHP Version: SQA assignments:
Browser:Google Chrome

Description

Basically when you delete (and possibly add) an attachment from a draft thread it posts it automatically rather than saving it back to drafts.

To replicate:

Make a new post, attach a file and save to drafts. Then edit this draft and delete the attachment, it will post the thread automatically.

I have only tested this on the mybboard.net website thus far.

Associated revisions

Revision 4691
Added by Tom Moore about 2 years ago

Fixes Posts after updating the attachments of drafts (fixes:586)

Revision 4696
Added by Tom Moore about 2 years ago

Improves Posts after updating the attachments of drafts (improves:586)

History

#1
Updated by Tim B. about 2 years ago

Ok, I just tested it a bit more on localhost (a vanilla 1.4.10 install), it definitely posts the thread if you delete an attachment from a draft but also if you add an attachment it makes an entirely new post, quoting the draft post without the attachment!

#2
Updated by Nick Palmer about 2 years ago

  • Status changed from New to Confirmed

#3
Updated by Tom Moore about 2 years ago

  • Status changed from Confirmed to Assigned
  • Assignee set to Tom Moore
  • Target version set to 1.4.12

#4
Updated by Tom Moore about 2 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset r4691.

#5
Updated by Tom Moore about 2 years ago

Can SQA please test this for all circumstances; such as a draft new thread, draft new post, with/without attachments, removing attachments from the draft then post etc. etc.

There were plenty of more little bugs in this report than what was reported (such as missing subjects from drafts) which I've tried to fix. It works for me, but obviously tests in other environments need to be done...

#6
Updated by Michael Malin over 1 year ago

One little bug: If I make a regular thread, I do not click "Upload Attachment", but when I publish the article, he invites himself up. In a draft of the annex of a direct storage will be discarded as a draft.

#7
Updated by Dennis Tsang over 1 year ago

Sorry Michael, I didn't understand your last message.

#8
Updated by Michael Malin over 1 year ago

If I create a normal thread, I can easily add an attachment, without extra clicking on the Upload button. If I save it as a draft, it will not do this.

#9
Updated by Ryan Gordon over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF