Bug #598

Split thread - post icon

Added by Stefan T. about 2 years ago. Updated almost 2 years ago.

Status:Closed Start date:12/19/2009
Priority:Normal Due date:
Assignee:Huji Lee % Done:

100%

Category:Moderation
Target version:1.4.12
Reproducibility:Always Database Type:
Reported In MyBB Version:1.4.10 Database Version:
PHP Version: SQA assignments:
Browser:

Description

When you split a thread, the new thread has the same icon as the original thread although the first post of the new one has no icon.

Associated revisions

Revision 4736
Added by Huji Lee about 2 years ago

Fixes Split thread - post icon (fixes:598)

History

Updated by Tom Moore about 2 years ago

I don't get this one Stefan. I've created a thread with 4 posts, and split the last two into a new thread. All 4 posts have post icons.

In the new thread, the icons display as they did in the original thread. Both threads share the same post icon in the forum index too.

Is there something I'm missing here?

Updated by Stefan T. about 2 years ago

The new thread has an icon (forumdisplay), but the first post icon of this thread has no icon (showthread).

Updated by Tom Moore about 2 years ago

Problem definitely doesn't exist for me; using r4698 trunk, 5.3.0 and mySQL 5.1...

Updated by Stefan T. about 2 years ago

I sent you a PM.

Updated by Tom Moore about 2 years ago

OK, I see what you mean. The firstpost of the thread has a post icon, but the second post doesn't.

When the thread is split, the post icon goes to both threads - but the first post of the new thread (the second one in the original thread, which didn't have an icon) doesn't have an icon.

I'm not sure whether it's meant to happen or not, as looking at the code, it copies the thread icon (not the post icon) when splitting threads. I'll leave it until Ryan notices this, but personally, it's doing what it's told to do and not really a bug in my opinion (as it, the first split post doesn't have an icon).

I guess if the first post doesn't have an icon, then the thread icon should be removed.

Updated by Ryan Gordon about 2 years ago

Yes, sounds like the correct bug fix is to unset the post icon in the thread row if the post you split from doesn't have a post icon.

Updated by Huji Lee about 2 years ago

  • Assignee set to Huji Lee
  • Target version set to 1.4.12

Updated by Huji Lee about 2 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset r4736.

Updated by Stefan T. almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF