Bug #600

Intensive loop in functions_time.php

Added by Ryan Gordon 3 months ago. Updated 3 months ago.

Status:Closed Start:12/19/2009
Priority:Normal Due date:
Assigned to:Ryan Gordon % Done:

100%

Category:Performance
Target version:1.4.11
Reproducibility:Rarely Browser:
Reported In MyBB Version:1.4.10 Database Type:
PHP Version: Database Version:

Description

Under very certain and rare circumstances, it is possible to make a portion of code in functions_time.php (a loop) run millions of times before it stops. This can cause long page loads where functions_time.php is used (just the member.php page by the looks of it) and raise the server load. Therefore this is being categorized as a performance issue. The fix is small and simple and will be updated in the MyBB 1.4.10 package. An announcement on the MyBB blog will be made for those users who wish to apply the fix [it will be recommended]. A new release will not be made considering the severity of this problem is minimal and because a MyBB 1.6 release is not too far out.

Associated revisions

Revision 4613
Added by Ryan Gordon 3 months ago

Fixes Intensive loop in functions_time.php (fixes:600)

Revision 4620
Added by Dennis Tsang 3 months ago

Validating input for return date (improves:600)
Fixing check for past return date(fixes:603)

Revision 4633
Added by Dennis Tsang 3 months ago

Screwed up the last commit...sorry. Changed the fix so that if you enter in a year 10000+ it will save as 9999 and not truncate to the first 4 characters (improves:600)

History

Updated by Ryan Gordon 3 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset r4613.

Updated by Dennis Tsang 3 months ago

  • Target version changed from 1.4.10 to 1.4.11

Updated by Dennis Tsang 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF