Bug #660

forumdisplay_rules not cached

Added by Jesse Labrocca about 2 years ago. Updated almost 2 years ago.

Status:Closed Start date:01/08/2010
Priority:Normal Due date:
Assignee:Tom Moore % Done:

100%
Category:Performance
Target version:1.4.12
Reproducibility:Always Database Type:
Reported In MyBB Version:1.6.0 Database Version:
PHP Version: SQA assignments:
Browser:

Description

The template forumdisplay_rules is not cached as part of forumdisplay.php.

Associated revisions

Revision 4744
Added by Tom Moore about 2 years ago

Fixes forumdisplay_rules not cached (fixes:660)

History

#1
Updated by Ryan Gordon about 2 years ago

  • Target version deleted (1.4.12)

You don't get to set Target versions :)

This will likely be put into 1.6.

#2
Updated by Tom Moore about 2 years ago

  • Status changed from New to Confirmed
  • Assignee set to Tom Moore

Just ran into this; I thought 1.4.12 is the 'last' maintenance for the 1.4 series - surely we should be making sure it's as complete as possible, this included?

#3
Updated by Ryan Gordon about 2 years ago

It's a nothing bug fix. 1.4.12's quality isn't going to change because of this fix, but whatever. Less changes in a maintenance release means the release is more likely to not have problems.

#4
Updated by Dennis Tsang about 2 years ago

  • Target version set to 1.4.12

One less query is one bit better in quality. I'd like to see this in 1.4.12. I don't think it's difficult, unless I'm missing something.

#5
Updated by Ryan Gordon about 2 years ago

No actually, it's one bit more in memory overhead and an increase in hit-and-miss cache ratio. While it removes one query, that means nothing as queries like this take between milliseconds and microseconds. You're dedicating a whole developer, bug fix, ticket, and SQA approval to removing a spec of dust.

#6
Updated by Jesse Labrocca about 2 years ago

Some of us use inline forum rules for our sites and imho this is also a matter of consistency. The time you took to reply Ryan is probably the same time to simply add the template to the page.

If you want to call this a spec of dust that's fine but when you want a very clean house you want that dust picked up.

If you decide not to bother fixing this someone in the future will probably report it again and waste more time of staff than if you just fix it now.

#7
Updated by Ryan Gordon about 2 years ago

Not unless I decide to start simply rejecting all of these bug reports as the real "fix" will be in MyBB 2.0.

#8
Updated by Jesse Labrocca about 2 years ago

That's reasonable. Thanks.

#9
Updated by Ryan Gordon about 2 years ago

  • Status changed from Confirmed to Assigned

#10
Updated by Tom Moore about 2 years ago

  • Reported In MyBB Version changed from 1.4.11 to 1.6.0

#11
Updated by Tom Moore about 2 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset r4744.

#12
Updated by Stefan T. almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF