Bug #689

Usercp.php + Modcp.php - XHTML 1.0 Problem ($bdaymonthsel)

Added by Craig Whiteside about 2 years ago. Updated about 2 years ago.

Status:Closed Start date:01/20/2010
Priority:Normal Due date:
Assignee:Huji Lee % Done:

100%
Category:User Control Panel
Target version:1.4.12
Reproducibility:Always Database Type:MySQL
Reported In MyBB Version:1.4.11 Database Version:5.0.87
PHP Version:5.2.11 SQA assignments:
Browser:Mozilla Firefox 3.6

Description

There is a mistake for the variable $bdaymonthsel on both Usercp.php and Modcp.php

For the Modcp.php (Line: 1666) it is currently

$bdaymonthsel[$mybb->input['birthday_month']] = "selected";

It should be

$bdaymonthsel[$mybb->input['birthday_month']] = "selected=\"selected\"";

and for Usercp.php (Line: 302) it is

$bdaymonthsel[$bday[1]] = "selected";

and it should be

$bdaymonthsel[$bday[1]] = "selected=\"selected\"";

selected is incorrect as it breaks XHTML 1.0 Transitional rules, select="selected" is the correct format.

Associated revisions

Revision 4729
Added by Huji Lee about 2 years ago

Fixes Usercp.php + Modcp.php - XHTML 1.0 Problem ($bdaymonthsel) (fixes:689)

History

#1
Updated by Ryan Gordon about 2 years ago

  • Target version deleted (1.4.12)

#2
Updated by Craig Whiteside about 2 years ago

Fixed typo for last sentence:

selected is incorrect as it breaks XHTML 1.0 Transitional rules, selected="selected" is the correct format.

#3
Updated by Huji Lee about 2 years ago

  • Assignee set to Huji Lee

#4
Updated by Huji Lee about 2 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset r4729.

#5
Updated by Huji Lee about 2 years ago

  • Target version set to 1.4.12

#6
Updated by Stefan T. about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF