Bug #839

Unneeded comma in forumdisplay.php

Added by Markus Mälkönen about 2 years ago. Updated 13 days ago.

Status:Closed Start date:04/01/2010
Priority:Normal Due date:
Assignee:Tom Moore % Done:

100%
Category:Forum Display
Target version:1.6.0 Beta
Reproducibility:Always Database Type:MySQLi
Reported In MyBB Version:1.6.0 Database Version:5.1.44
PHP Version:5.2.13 SQA assignments:
Browser:

Description

If forum moderator is set, forumdisplay.php page show unneeded comma.

unneeded_comma.png (9.5 kB) Markus Mälkönen, 04/01/2010 02:20 pm

unneeded_comma_16.png - Unneeded comma in MyBB 1.6 (7.6 kB) Markus Mälkönen, 04/02/2010 05:22 pm

unneeded_comma_index.png - MyBB 1.6 and unneeded comma in index.php (4.6 kB) Markus Mälkönen, 04/02/2010 05:43 pm

Associated revisions

Revision 4893
Added by Tom Moore about 2 years ago

Fixes Unneeded comma in forumdisplay.php (fixes:839)

History

#1 Updated by Doug Sisk about 2 years ago

I cannot reproduce. Are you using a custom theme?

#2 Updated by Markus Mälkönen about 2 years ago

Doug Sisk wrote:

I cannot reproduce. Are you using a custom theme?

No, I use default theme. This bug also seems in MyBB 1.6.

Reproduce instructions:
1. Create two account and set both forum moderator in same forum
2. Merge these users
3. Go to forumdisplay.php and see bug.

#3 Updated by Matt Rogowski about 2 years ago

  • Reported In MyBB Version changed from 1.4.11 to 1.6.0

If it's in 1.6 it would be useful to set that as the reported in version rather than 1.4.11 :)

#4 Updated by Markus Mälkönen about 2 years ago

I can see same bug in index.php.

#5 Updated by Matt Rogowski about 2 years ago

  • Status changed from New to Confirmed

I'll change this to confirmed as I can reproduce.

#6 Updated by Dennis Tsang about 2 years ago

Probably the key thing that was missing is that the moderators were merged? I'd suspect the moderator rows aren't removed correctly when users are merged.

Next time, if you had posted the detailed reproduction instructions to begin with, we would have been able to see it immediately.

#7 Updated by Tom Moore about 2 years ago

  • Status changed from Confirmed to Assigned
  • Assignee set to Tom Moore
  • Target version set to 1.6.0 Beta

#8 Updated by Tom Moore about 2 years ago

  • Status changed from Assigned to Resolved
  • % Done changed from 0 to 100

Applied in changeset r4893.

This revision removes the moderator field in the database, removing the comma too.

I wasn't too sure whether to do this, or change the moderator field to the new user. Obviously if you're merging users, then all posts, threads etc. become the destination user's info. I wasn't entirely sure whether they should inherit moderator permissions too - sounds a little awkward to me.

#9 Updated by Stefan T. about 2 years ago

  • Status changed from Resolved to Closed

If you think we shouldn't remove all permissions of source user, reopen this ticket. ;)

Also available in: Atom PDF